Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

2020-07-14 Thread Stephen Hemminger
On Tue, 14 Jul 2020 11:46:00 + "Pattan, Reshma" wrote: > > -Original Message- > > From: wangzk...@163.com On Behalf Of Zhike Wang > > + "[snaplen=default:0, meaning no > > truncation]'\n", > > From pdump changes, below are couple of comments. > > Bit more descri

Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

2020-07-14 Thread Ferruh Yigit
On 7/14/2020 9:26 AM, Zhike Wang wrote: > Introduced "snaplen=" option. It is convenient to truncate > large packets to only capture necessary headers. > > Signed-off-by: Zhike Wang <...> > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index 668cbd1..0d2a4b3 1

[dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

2020-07-14 Thread Zhike Wang
Introduced "snaplen=" option. It is convenient to truncate large packets to only capture necessary headers. Signed-off-by: Zhike Wang --- app/pdump/main.c | 32 ++- doc/guides/rel_notes/release_20_08.rst | 4 doc/guides/tools/pdump.rst

Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

2020-07-14 Thread Pattan, Reshma
> -Original Message- > From: wangzk...@163.com On Behalf Of Zhike Wang > + "[snaplen=default:0, meaning no > truncation]'\n", >From pdump changes, below are couple of comments. Bit more descriptive would be nice, how about, disables truncation of captured packets