[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-08 Thread Ferruh Yigit
On 7/8/2016 2:23 PM, Bruce Richardson wrote: > On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: >> On 6/30/2016 4:04 PM, Jan Medala wrote: >>> Signed-off-by: Alexander Matushevsky >>> Signed-off-by: Jakub Palider >>> Signed-off-by: Jan Medala >> >> The compilation error to fix is [1

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-08 Thread Bruce Richardson
On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > On 6/30/2016 4:04 PM, Jan Medala wrote: > > Signed-off-by: Alexander Matushevsky > > Signed-off-by: Jakub Palider > > Signed-off-by: Jan Medala > > The compilation error to fix is [1], it may be good to add what to fix > into commi

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-06 Thread Jan Mędala
There are no obstacles. We first produced patches 1-5, then tested on different compilers so patch no. 6 was made. Thank you Bruce for support! I'm still learning DPDK's submission/upstream process so all comments and gained knowledge will easier future patches. Jan 2016-07-06 10:14 GMT+02:00

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-06 Thread Bruce Richardson
On Tue, Jul 05, 2016 at 07:10:54PM +0200, Jan M?dala wrote: > Let me point it this way: > ??This patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA communication layer > > Jan Since it fixes another patch in the same series, I think the two patches could actually be merged, rather than adding co

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-05 Thread Jan Mędala
Let me point it this way: ??This patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA communication layer Jan 2016-07-05 19:04 GMT+02:00 Jan M?dala : > Uhm, wait, I think that sha is wrong, please let me check it double time. > > Jan > > 2016-07-05 19:03 GMT+02:00 Jan M?dala : > >> Bruce, >> >>

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-05 Thread Jan Mędala
Uhm, wait, I think that sha is wrong, please let me check it double time. Jan 2016-07-05 19:03 GMT+02:00 Jan M?dala : > Bruce, > > > That'd be very kind of you if you can fix trailing zeros. > > > This patch > > Fixes: b5b8cd9 ("ena: update of ENA communication layer") > > > Regards, > > Jan

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-05 Thread Jan Mędala
Bruce, That'd be very kind of you if you can fix trailing zeros. This patch Fixes: b5b8cd9 ("ena: update of ENA communication layer") Regards, Jan 2016-07-05 18:19 GMT+02:00 Bruce Richardson : > On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > > On 6/30/2016 4:04 PM, Jan

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-05 Thread Bruce Richardson
On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > On 6/30/2016 4:04 PM, Jan Medala wrote: > > Signed-off-by: Alexander Matushevsky > > Signed-off-by: Jakub Palider > > Signed-off-by: Jan Medala > > The compilation error to fix is [1], it may be good to add what to fix > into commi

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-07-05 Thread Ferruh Yigit
On 6/30/2016 4:04 PM, Jan Medala wrote: > Signed-off-by: Alexander Matushevsky > Signed-off-by: Jakub Palider > Signed-off-by: Jan Medala The compilation error to fix is [1], it may be good to add what to fix into commit log. [1] == Build drivers/net/ena CC ena_ethdev.o /tmp/dpdk_maintain/en

[dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

2016-06-30 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jakub Palider Signed-off-by: Jan Medala --- drivers/net/ena/ena_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index f8dbde4..a8c2b9c 100644 -