Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

2018-04-27 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 04:39:34PM +0100, Burakov, Anatoly wrote: > On 27-Apr-18 4:18 PM, Bruce Richardson wrote: > > On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: > > > We close fd if we managed to find it in the list of allocated > > > segment lists (which should always be the

Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 4:18 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: We close fd if we managed to find it in the list of allocated segment lists (which should always be the case under normal conditions), but if we didn't, the fd was leaking. Close it if

Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 4:18 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: We close fd if we managed to find it in the list of allocated segment lists (which should always be the case under normal conditions), but if we didn't, the fd was leaking. Close it if

Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

2018-04-27 Thread Bruce Richardson
On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: > We close fd if we managed to find it in the list of allocated > segment lists (which should always be the case under normal > conditions), but if we didn't, the fd was leaking. Close it if > we couldn't find it in the segment list.

[dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak

2018-04-25 Thread Anatoly Burakov
We close fd if we managed to find it in the list of allocated segment lists (which should always be the case under normal conditions), but if we didn't, the fd was leaking. Close it if we couldn't find it in the segment list. This is not an issue as if the segment is zero length, we're getting rid