On 27-Apr-18 4:18 PM, Bruce Richardson wrote:
On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote:
We close fd if we managed to find it in the list of allocated
segment lists (which should always be the case under normal
conditions), but if we didn't, the fd was leaking. Close it if
we couldn't find it in the segment list. This is not an issue
as if the segment is zero length, we're getting rid of it
anyway, so there's no harm in not storing the fd anywhere.
Coverity issue: 272568
This coverity issue indicates two resource leaks, while I think this patch
only closes one of them.
The other issue is actually a false positive. We couldn't have gotten
the fd if there wasn't a tailq entry for that fd, but if we don't resize
and remove the file, we want to keep the fd. So the "int fd" goes out of
scope, but actually it's stored in the tailq, and thus doesn't leak.
--
Thanks,
Anatoly
