[dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size

2014-10-27 Thread Thomas Monjalon
2014-10-27 13:21, Matthew Hall: > On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote: > > You didn't answer to my previous comment on this. > > I think these definitions are useless. 64 is 64. > > Putting labels on the constants gives meaning to them as well as a numeric > value. Not

[dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size

2014-10-27 Thread Thomas Monjalon
2014-10-22 19:53, Helin Zhang: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -430,6 +430,9 @@ struct rte_eth_rss_conf { > /* Definitions used for redirection table entry size */ > #define ETH_RSS_RETA_NUM_ENTRIES 128 > #define ETH_RSS_RETA_MAX_QUEUE 16 > +#de

[dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size

2014-10-27 Thread Matthew Hall
On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote: > You didn't answer to my previous comment on this. > I think these definitions are useless. 64 is 64. Putting labels on the constants gives meaning to them as well as a numeric value. Not doing so is an antipattern referred to as "

[dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size

2014-10-22 Thread Helin Zhang
Add support of setting hash lookup table size according to the hardawre capability. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_ethdev.h | 3 +++ lib/librte_pmd_i40e/i40e_ethdev.c | 14 +- lib/librte_pmd_i40e/i40e_ethdev.h | 1 + 3 files changed, 17 insertions(+), 1 del