Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-17 Thread Jerin Jacob
On Fri, Sep 4, 2020 at 3:49 PM Liang Ma wrote: > > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these inst

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-16 Thread Liang, Ma
On 04 Sep 11:42, Stephen Hemminger wrote: we have discussed with arm developer in the past. Please ref https://patches.dpdk.org/patch/70662/ There was no objection, in my opinoin. Also the API we proposed has experimental tag, other vendor still can change it. For the ethdev internal ops we int

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
On 04 Sep 11:42, Stephen Hemminger wrote: we are very open to discuss design with other vendor. > Before this is merged, please work with Arm maintainers to have a version that > works on Arm 64 as well. Don't think this should be merged unless the two > major > platforms supported by DPDK can w

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
Hi Stephen, v4 patch will include the l3fwd-power udpate. Regards Liang On 04 Sep 09:37, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:55 +0100 > Liang Ma wrote: > > > Add two new power management intrinsics, and provide an implementation > > in eal/x86 based on UMONITOR/UMWAIT instru

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
Hi Stephen, Agree. v4 will address this. Regards Liang On 04 Sep 09:23, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:55 +0100 > Liang Ma wrote: > > > + * > > + * @return > > + * Architecture-dependent return value. > > + */ > > +static inline int rte_power_monitor(const volatile voi

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-06 Thread Ananyev, Konstantin
> diff --git a/lib/librte_eal/x86/include/rte_power_intrinsics.h > b/lib/librte_eal/x86/include/rte_power_intrinsics.h > new file mode 100644 > index 00..6dd1cdc939 > --- /dev/null > +++ b/lib/librte_eal/x86/include/rte_power_intrinsics.h > @@ -0,0 +1,143 @@ > +/* SPDX-License-Identifier

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these i

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these i

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 11:18:55 +0100 Liang Ma wrote: > + * > + * @return > + * Architecture-dependent return value. > + */ > +static inline int rte_power_monitor(const volatile void *p, > + const uint64_t expected_value, const uint64_t value_mask, > + const uint32_t state,

[dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-04 Thread Liang Ma
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar