[dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations

2016-06-15 Thread Thomas Monjalon
2016-06-15 10:17, Remy Horton: > +enum rte_keepalive_state { > + RTE_UNUSED = 0, > + RTE_ALIVE = 1, > + RTE_MISSING = 4, > + RTE_DEAD = 2, > + RTE_GONE = 3, > + RTE_DOZING = 5, > + RTE_SLEEP = 6 > +}; I'm concerned about the namespace here. RTE_UNUSED and others have a

[dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations

2016-06-15 Thread Remy Horton
On 15/06/2016 10:27, Thomas Monjalon wrote: [..] > I'm concerned about the namespace here. > RTE_UNUSED and others have a chance to not be unique enough. > Is it possible to have a longer prefix like RTE_KA_ or RTE_STATE_ > or RTE_KA_STATE_? > Good point - I'll go with RTE_KA_STATE_ as it is most

[dpdk-dev] [PATCH v3 1/3] eal: export keepalive state enumerations

2016-06-15 Thread Remy Horton
Changes the keepalive state from an anonymous enum to a declared one which is externally visible, so that keepalive enum values can be used by applications. Signed-off-by: Remy Horton --- lib/librte_eal/common/include/rte_keepalive.h | 12 +- lib/librte_eal/common/rte_keepalive.c