[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-05-09 Thread Yuanhan Liu
On Mon, May 09, 2016 at 07:58:26AM +, Tan, Jianfeng wrote: > Hi Yuanhan, > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Thursday, May 5, 2016 11:20 AM > > To: Tan, Jianfeng > > Cc: dev at dpdk.org; Xie, Huawei > > Subject: Re: [PATCH v3

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-05-09 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:20 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() > > On Fri, Apr 29, 2016 at 12:

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-05-04 Thread Yuanhan Liu
On Fri, Apr 29, 2016 at 12:48:45AM +, Jianfeng Tan wrote: > + if (queue_type < VTNET_RQ || queue_type > VTNET_CQ) { > + PMD_INIT_LOG(ERR, "invalid queue type: %d", queue_type); > + return -EINVAL; > } I'm thinking this check is not necessary. We can make sure

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-04-29 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 47 +++--- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 1fe90ae..b3f4158 100644 --- a/drivers/net/