[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

[Tan, Jianfeng]

Hi Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, May 5, 2016 11:20 AM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org; Xie, Huawei
> Subject: Re: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()
> 
> On Fri, Apr 29, 2016 at 12:48:45AM +0000, Jianfeng Tan wrote:
> > +   if (queue_type < VTNET_RQ || queue_type > VTNET_CQ) {
> > +           PMD_INIT_LOG(ERR, "invalid queue type: %d", queue_type);
> > +           return -EINVAL;
> >     }
> 
> I'm thinking this check is not necessary. We can make sure it's a valid
> queue type.

Yes, this is not necessary, and I was also entangled with whether to keep it or 
not. And ok, I'll send a new version with this check removed.

Thanks,
Jianfeng

> 
>       --yliu