Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2019-01-25 Thread Andriy Berestovskyy
Sure, Ferruh. Just let me know how can I help you. Andriy > On 23 Jan 2019, at 19:36, Ferruh Yigit wrote: > >> On 5/24/2018 10:20 AM, Andriy Berestovskyy wrote: >> Hi Shahaf, >> >>> On 23 May 2018, at 07:21, Shahaf Shuler wrote: >>> I think this patch addressing just small issue in a bigger p

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2019-01-23 Thread Ferruh Yigit
On 5/24/2018 10:20 AM, Andriy Berestovskyy wrote: > Hi Shahaf, > >> On 23 May 2018, at 07:21, Shahaf Shuler wrote: >> I think this patch addressing just small issue in a bigger problem. >> The way I see it all application needs to specify is the max packet size it >> expects to receive, nothing

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2018-05-24 Thread Andriy Berestovskyy
Hi Shahaf, > On 23 May 2018, at 07:21, Shahaf Shuler wrote: > I think this patch addressing just small issue in a bigger problem. > The way I see it all application needs to specify is the max packet size it > expects to receive, nothing else(!). [...] > IMO The "jumbo_frame" bit can be set b

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2018-05-22 Thread Jerin Jacob
" > , "hemant.agra...@nxp.com" > , "jerin.ja...@cavium.com" > > Subject: RE: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame > size in configure() > > Hi Andriy, > > I think this patch addressing just small issue in a bigger problem. &

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2018-05-22 Thread Shahaf Shuler
Hi Andriy, I think this patch addressing just small issue in a bigger problem. The way I see it all application needs to specify is the max packet size it expects to receive, nothing else(!). Currently we are forcing it to toggle multiple redundant fields. Wednesday, May 23, 2018 1:31 AM, Thom

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2018-05-22 Thread Thomas Monjalon
This proposal had no conclusion. The examples have been fixed: http://dpdk.org/commit/5e470a6654 But there is still an inconsistency in the API: " - for normal frames: zero max_rx_pkt_len uses a default - for jumbo frames: zero max_rx_pkt_len gives an error " 01/08/2017 00:33, Thomas M

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-07-31 Thread Thomas Monjalon
We are missing some comments about this proposal. 24/04/2017 16:50, Andriy Berestovskyy: > Hey Thomas, > > On 21.04.2017 00:25, Thomas Monjalon wrote: > >> The hardware is different, there is not much we can do about it. > > > > We can return an error if the max_rx_pkt_len cannot be set in the NI

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-24 Thread Andriy Berestovskyy
Hey Thomas, On 21.04.2017 00:25, Thomas Monjalon wrote: The hardware is different, there is not much we can do about it. We can return an error if the max_rx_pkt_len cannot be set in the NIC. Yes, we pass the value to the PMD, which might check the value and return an error. >> Neverthele

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-20 Thread Thomas Monjalon
07/04/2017 17:27, Andriy Berestovskyy: > Hey Thomas, > > On 07.04.2017 16:47, Thomas Monjalon wrote: > >> What if we add to the max_rx_pkt_len description: "the effective maximum > >> RX frame size depends on PMD, please refer the PMD guide for the > >> details"? > > > > I think the problem is no

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
Hey Thomas, On 07.04.2017 16:47, Thomas Monjalon wrote: What if we add to the max_rx_pkt_len description: "the effective maximum RX frame size depends on PMD, please refer the PMD guide for the details"? I think the problem is not in the documentation but in the implementations which should be

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Thomas Monjalon
2017-04-07 16:18, Andriy Berestovskyy: > Hey Bruce, > > On 07.04.2017 14:29, Bruce Richardson wrote: > > Is this entirely hidden from drivers? As I said previously, I believe > > NICs using ixgbe/i40e etc. only use the frame size value when the jumbo > > frame flag is set. That may lead to further

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
Hey Bruce, On 07.04.2017 14:29, Bruce Richardson wrote: Is this entirely hidden from drivers? As I said previously, I believe NICs using ixgbe/i40e etc. only use the frame size value when the jumbo frame flag is set. That may lead to further inconsistent behaviour unless all NICs are set up to b

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Bruce Richardson
On Fri, Apr 07, 2017 at 02:15:47PM +0200, Thomas Monjalon wrote: > 2017-04-07 13:02, Andriy Berestovskyy: > > At the moment rte_eth_dev_configure() behaves inconsistent: > > - for normal frames: zero max_rx_pkt_len uses a default > > - for jumbo frames: zero max_rx_pkt_len gives an error > > > >

Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Thomas Monjalon
2017-04-07 13:02, Andriy Berestovskyy: > At the moment rte_eth_dev_configure() behaves inconsistent: > - for normal frames: zero max_rx_pkt_len uses a default > - for jumbo frames: zero max_rx_pkt_len gives an error > > This patch fixes this inconsistency by using a default value > if max_rx_pkt

[dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure()

2017-04-07 Thread Andriy Berestovskyy
At the moment rte_eth_dev_configure() behaves inconsistent: - for normal frames: zero max_rx_pkt_len uses a default - for jumbo frames: zero max_rx_pkt_len gives an error This patch fixes this inconsistency by using a default value if max_rx_pkt_len is zero both for normal and jumbo frames. Sig