Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Thursday, July 15, 2021 6:02 PM > To: Bruce Richardson > Cc: Nipun Gupta ; fengchengwen > ; tho...@monjalon.net; ferruh.yi...@intel.com; > jer...@marvell.com; andrew.rybche...@oktetlabs.ru; dev@dpdk.org; > m...@smartsharesystems.com; Hema

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 5:41 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 11:16:54AM +, Nipun Gupta wrote: > > > > > > > -Original Message- > > > From: fengchengwen > > > Sent: Thursday, July 15, 2021 1:59 PM > > > To: Nipun Gupta ; tho...@monjalon.net; > > > ferruh.yi...@in

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 11:16:54AM +, Nipun Gupta wrote: > > > > -Original Message- > > From: fengchengwen > > Sent: Thursday, July 15, 2021 1:59 PM > > To: Nipun Gupta ; tho...@monjalon.net; > > ferruh.yi...@intel.com; bruce.richard...@intel.com; jer...@marvell.com; > > jerinjac...@

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Nipun Gupta
> -Original Message- > From: fengchengwen > Sent: Thursday, July 15, 2021 1:59 PM > To: Nipun Gupta ; tho...@monjalon.net; > ferruh.yi...@intel.com; bruce.richard...@intel.com; jer...@marvell.com; > jerinjac...@gmail.com; andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; m...@smartshares

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 11:03:08AM +0100, Bruce Richardson wrote: > On Thu, Jul 15, 2021 at 03:00:01PM +0530, Jerin Jacob wrote: > > On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson > > wrote: > > > > > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > > > ) > > > > a > > > > > >

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 03:00:01PM +0530, Jerin Jacob wrote: > On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson > wrote: > > > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > > ) > > > a > > > > > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng > > > wrote: > > > > > > > > Th

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 03:19:55PM +0530, Jerin Jacob wrote: > On Thu, Jul 15, 2021 at 1:55 PM Bruce Richardson > wrote: > > > > On Thu, Jul 15, 2021 at 12:14:05PM +0530, Jerin Jacob wrote: > > > On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson > > > wrote: > > > > > > > > On Tue, Jul 13, 2021 at

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 1:55 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 12:14:05PM +0530, Jerin Jacob wrote: > > On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson > > wrote: > > > > > > On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > > > > > > 4. COMMENT:> + uint

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > ) > > a > > > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng > > wrote: > > > > > > This patch introduce 'dmadevice' which is a generic type of DMA > > > device. > > > >

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > ) > a > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng wrote: > > > > This patch introduce 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enabl

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
On 2021/7/14 20:22, Nipun Gupta wrote: > > >> +/** >> + * A structure used to configure a virtual DMA channel. >> + */ >> +struct rte_dmadev_vchan_conf { >> +uint8_t direction; >> +/**< Set of supported transfer directions >> + * @see RTE_DMA_MEM_TO_MEM >> + * @see RTE_DMA_MEM_TO_

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 12:14:05PM +0530, Jerin Jacob wrote: > On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson > wrote: > > > > On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > > > > 4. COMMENT:> + uint64_t reserved[4]; /**< Reserved for future > > > fields */ > > > > +}; >

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
) a On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Jerin Jacob
On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson wrote: > > On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > > Thank you for your valuable comments, and I think we've taken a big step > > forward. > > > > @andrew Could you provide the copyright line so that I can add it to > > rel

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Bruce Richardson
On Tue, Jul 13, 2021 at 08:27:43PM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Nipun Gupta
> +/** > + * A structure used to configure a virtual DMA channel. > + */ > +struct rte_dmadev_vchan_conf { > + uint8_t direction; > + /**< Set of supported transfer directions > + * @see RTE_DMA_MEM_TO_MEM > + * @see RTE_DMA_MEM_TO_DEV > + * @see RTE_DMA_DEV_TO_MEM > +

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-13 Thread Bruce Richardson
On Tue, Jul 13, 2021 at 08:27:43PM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-13 Thread Bruce Richardson
On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > Thank you for your valuable comments, and I think we've taken a big step > forward. > > @andrew Could you provide the copyright line so that I can add it to relevant > file. > > @burce, jerin Some unmodified review comments are re

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-13 Thread fengchengwen
Thank you for your valuable comments, and I think we've taken a big step forward. @andrew Could you provide the copyright line so that I can add it to relevant file. @burce, jerin Some unmodified review comments are returned here: 1. COMMENT: We allow up to 100 characters per line for DPDK co

[dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-13 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v3: * rm reset and fill_sg ops. * rm MT-safe capabilities. * add submit