Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-06-19 Thread Thomas Monjalon
19/06/2019 18:08, Akhil Goyal: > Hi Fan, > > > > > > Hi Akhil, > > > > > > This patch was sent in 19.05 but I just found it can be applied to 19.08 > > > RC0 > > > cleanly. > > > Do you think I need to send a v4 (with no change) for 19.08? > > > > > No need to send a v4, I will take v3. Planning t

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-06-19 Thread Akhil Goyal
Hi Fan, > > > > Hi Akhil, > > > > This patch was sent in 19.05 but I just found it can be applied to 19.08 RC0 > > cleanly. > > Do you think I need to send a v4 (with no change) for 19.08? > > > No need to send a v4, I will take v3. Planning to take some patches next week. > Will let you know in ca

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-05-28 Thread Akhil Goyal
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, May 28, 2019 3:22 PM > To: Akhil Goyal ; Thomas Monjalon > > Cc: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > > Subject: RE: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-05-28 Thread Zhang, Roy Fan
2 PM > To: Thomas Monjalon > Cc: Zhang, Roy Fan ; dev@dpdk.org; Trahe, Fiona > ; Kusztal, ArkadiuszX > Subject: Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer > constant > > > > On 3/29/2019 9:18 PM, Akhil Goyal wrote: > > > > On 3/29/2019 7:49

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-29 Thread Akhil Goyal
On 3/29/2019 9:18 PM, Akhil Goyal wrote: > > On 3/29/2019 7:49 PM, Thomas Monjalon wrote: >> 29/03/2019 15:07, Akhil Goyal: >>> On 3/20/2019 7:02 PM, Fan Zhang wrote: drivers/common/cpt/cpt_ucode.h | 14 ++--- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c| 2

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-29 Thread Akhil Goyal
On 3/29/2019 7:49 PM, Thomas Monjalon wrote: > 29/03/2019 15:07, Akhil Goyal: >> On 3/20/2019 7:02 PM, Fan Zhang wrote: >>>drivers/common/cpt/cpt_ucode.h | 14 ++--- >>>drivers/crypto/aesni_gcm/aesni_gcm_pmd.c| 2 +- >>>drivers/crypto/aesni_mb/rte_aesni_mb_pmd.

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-29 Thread Thomas Monjalon
29/03/2019 15:07, Akhil Goyal: > On 3/20/2019 7:02 PM, Fan Zhang wrote: > > drivers/common/cpt/cpt_ucode.h | 14 ++--- > > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c| 2 +- > > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > > drivers/crypto/openssl/rte_opens

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-29 Thread Akhil Goyal
On 3/20/2019 7:02 PM, Fan Zhang wrote: > This patch changes the key pointer data types in cipher, auth, > and aead xforms from "uint8_t *" to "const uint8_t *" for a > more intuitive and safe sessionn creation. > > Signed-off-by: Fan Zhang > --- > v3: > - rebased on top of latest dpdk-next-crypt

Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-20 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, March 20, 2019 2:32 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; Trahe, > Fiona ; Kusztal, ArkadiuszX > > Subject: [PATCH v3] cryptodev: make xform key pointer constant > > This patch changes the key po

[dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

2019-03-20 Thread Fan Zhang
This patch changes the key pointer data types in cipher, auth, and aead xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and safe sessionn creation. Signed-off-by: Fan Zhang --- v3: - rebased on top of latest dpdk-next-crypto v2: - fixed a missed memory free for ixgbe ipsec dri