Hi Akhil, This patch was sent in 19.05 but I just found it can be applied to 19.08 RC0 cleanly. Do you think I need to send a v4 (with no change) for 19.08?
Regards, Fan > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, March 29, 2019 4:02 PM > To: Thomas Monjalon <tho...@monjalon.net> > Cc: Zhang, Roy Fan <roy.fan.zh...@intel.com>; dev@dpdk.org; Trahe, Fiona > <fiona.tr...@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v3] cryptodev: make xform key pointer > constant > > > > On 3/29/2019 9:18 PM, Akhil Goyal wrote: > > > > On 3/29/2019 7:49 PM, Thomas Monjalon wrote: > >> 29/03/2019 15:07, Akhil Goyal: > >>> On 3/20/2019 7:02 PM, Fan Zhang wrote: > >>>> drivers/common/cpt/cpt_ucode.h | 14 ++--- > >>>> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- > >>>> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > >>>> drivers/crypto/openssl/rte_openssl_pmd.c | 8 +-- > >>>> drivers/crypto/qat/qat_sym_session.c | 8 +-- > >>>> drivers/crypto/qat/qat_sym_session.h | 4 +- > >>>> drivers/crypto/snow3g/rte_snow3g_pmd.c | 23 ++++++-- > >>>> drivers/crypto/snow3g/rte_snow3g_pmd_private.h | 1 + > >>>> drivers/crypto/virtio/virtio_cryptodev.c | 30 +++++++--- > >>>> drivers/crypto/virtio/virtio_cryptodev.h | 2 + > >>>> drivers/net/ixgbe/ixgbe_ipsec.c | 35 +++++++++--- > >>>> drivers/net/ixgbe/ixgbe_ipsec.h | 3 +- > >>>> drivers/net/softnic/rte_eth_softnic_cli.c | 74 > >>>> ++++++++++++------ > ------- > >>>> drivers/net/softnic/rte_eth_softnic_internals.h | 4 ++ > >>>> examples/ip_pipeline/cli.c | 74 > >>>> ++++++++++++------------- > >>>> examples/ip_pipeline/cryptodev.c | 2 - > >>>> examples/ip_pipeline/pipeline.h | 6 ++ > >>>> examples/l2fwd-crypto/main.c | 40 +++++-------- > >>>> lib/librte_cryptodev/rte_crypto_sym.h | 12 ++-- > >>>> 19 files changed, 190 insertions(+), 154 deletions(-) > >>>> > >>>> > >>> I believe this patch should be applied to master. > >>> This has changes for net and virtio pmds. > >> It's all related to crypto code, you can take it in the crypto tree. > > Ok.. > > Applied to dpdk-next-crypto > This patch is taken back. As the changes introduce API breakage which needs > 1 release advance deprecation notice. > > > > > Thanks. > >>> for librte_cryptodev, and l2fwd-crypto > >>> > >>> Acked-by: Akhil Goyal <akhil.go...@nxp.com> > >>
