Re: [dpdk-dev] [PATCH v2 2/8] crypto/bcmfs: add vfio support

2020-09-29 Thread Vikas Gupta
Hi Akhil, On Tue, Sep 29, 2020 at 12:30 AM Akhil Goyal wrote: > > Hi Vikas, > > > Subject: [PATCH v2 2/8] crypto/bcmfs: add vfio support > > > > Add vfio support for device. > > > > Signed-off-by: Vikas Gupta > > Signed-off-by: Raveendra Padasalagi > > Reviewed-by: Ajit Khaparde > > --- > > d

Re: [dpdk-dev] [PATCH v2 2/8] crypto/bcmfs: add vfio support

2020-09-29 Thread Akhil Goyal
Hi Vikas, > > Hi Akhil, > > > > + > > > +#ifdef VFIO_PRESENT > > > > I cannot see VFIO_PRESENT flag defined in this patch. > > Hence the below code is a dead code and the patch > > Title is not justified as it says adding support for VFIO. > I believe VFIO_PRESENT flag is dependent on the platfor

Re: [dpdk-dev] [PATCH v2 2/8] crypto/bcmfs: add vfio support

2020-09-28 Thread Akhil Goyal
Hi Vikas, > Subject: [PATCH v2 2/8] crypto/bcmfs: add vfio support > > Add vfio support for device. > > Signed-off-by: Vikas Gupta > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ajit Khaparde > --- > drivers/crypto/bcmfs/bcmfs_device.c | 5 ++ > drivers/crypto/bcmfs/bcmfs_device.h |

[dpdk-dev] [PATCH v2 2/8] crypto/bcmfs: add vfio support

2020-08-13 Thread Vikas Gupta
Add vfio support for device. Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-by: Ajit Khaparde --- drivers/crypto/bcmfs/bcmfs_device.c | 5 ++ drivers/crypto/bcmfs/bcmfs_device.h | 6 ++ drivers/crypto/bcmfs/bcmfs_vfio.c | 107 drivers