Hi Vikas, > > Hi Akhil, > > > > + > > > +#ifdef VFIO_PRESENT > > > > I cannot see VFIO_PRESENT flag defined in this patch. > > Hence the below code is a dead code and the patch > > Title is not justified as it says adding support for VFIO. > I believe VFIO_PRESENT flag is dependent on the platform who supports > VFIO and determined in rte_vfio.h. > The driver will not work without VFIO support and returns silently > (functions in #else part). > Do you mean I need to change the title?
Title is OK. You can explain in the patch description and bcmfs.rst about how it is getting enabled, which config flags need to be enabled and probably in the bcmfs.rst as well. Regards, Akhil
