Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-06 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 6, 2017 6:27 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Helin ; Ananyev, > Konstantin ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e:

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-06 Thread Wu, Jingjing
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 6, 2017 6:29 PM > To: Wu, Jingjing > Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Helin > > Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx &

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-06 Thread Olivier Matz
On Mon, 6 Feb 2017 03:02:12 +, "Wu, Jingjing" wrote: > > > > Functionally will be same, but what do you think about following, > > to make easy to see what define adds: > > > > +#define I40E_TX_OFFLOAD_MASK ( \ > > + PKT_TX_IP_CKSUM |\ > > + PKT_TX_IP

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-06 Thread Olivier Matz
Hi Jingjing, On Sat, 4 Feb 2017 11:36:12 +0800, Jingjing Wu wrote: > Some Tx offload flags are missed in bitmask of all supported packet > Tx flags by i40e. > This patch fixes it. Could you detail which flag was missing? Is it PKT_TX_TUNNEL_MASK? If yes, shouldn't we have a "Fixes:" line? I th

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-05 Thread Wu, Jingjing
> > Functionally will be same, but what do you think about following, to make > easy to see what define adds: > > +#define I40E_TX_OFFLOAD_MASK (\ > + PKT_TX_IP_CKSUM |\ > + PKT_TX_IPV4 |\ > + PKT_TX_IPV6 |\ > +

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-05 Thread Ferruh Yigit
On 2/4/2017 3:36 AM, Jingjing Wu wrote: > Some Tx offload flags are missed in bitmask of all supported packet > Tx flags by i40e. > This patch fixes it. > > CC: helin.zh...@intel.com > Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/i40e

[dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-03 Thread Jingjing Wu
Some Tx offload flags are missed in bitmask of all supported packet Tx flags by i40e. This patch fixes it. CC: helin.zh...@intel.com Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_rxtx.c | 36 1 file