Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, August 23, 2017 5:57 PM > To: David Harton (dharton) > Cc: tho...@monjalon.net; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overrid

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Stephen Hemminger
On Tue, 22 Aug 2017 22:55:55 -0400 David Harton wrote: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero. > > Signed-off-by: David Harton > --- >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 23:27, David Harton (dharton): > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/08/2017 14:18, David Harton (dharton): > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 23/08/2017 04:55, David Harton: > > > > > rte_eth_stats_get() unconditonally would set rx_nom

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 23, 2017 9:24 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by > rte_eth_stats_get > > 23/08/2017 14:18, David Harton

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 14:18, David Harton (dharton): > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, August 23, 2017 3:52 AM > > To: David Harton (dharton) > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 23, 2017 3:52 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by > rte_eth_stats_get > > 23/08/2017 04:55, David Harton:

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 04:55, David Harton: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero. If we get this counter from stats->rx_nombuf, why keeping dev->da

[dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-22 Thread David Harton
rte_eth_stats_get() unconditonally would set rx_nombuf even if the device was setting the value. A check has been added in rte_eth_stats_get() to leave the device value in-tact when non-zero. Signed-off-by: David Harton --- v2: Fixed braces complaint required by other coding standards. lib/li