Hi,
> -Original Message-
> From: Chautru, Nicolas
> Sent: Wednesday, April 15, 2020 23:51
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Richardson, Bruce ; O'Hare, Cathal
> ; akhil.go...@nxp.com
> Subject: RE: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add
>
Hi
> From: Xu, Rosen
> Hi,
>
> > -Original Message-
> > From: Chautru, Nicolas
> > Sent: Tuesday, April 14, 2020 8:16
> > To: Xu, Rosen ; dev@dpdk.org; akhil.go...@nxp.com
> > Cc: Richardson, Bruce
> > Subject: RE: [dpdk-dev] [PATCH v2
Hi,
> -Original Message-
> From: Chautru, Nicolas
> Sent: Tuesday, April 14, 2020 8:16
> To: Xu, Rosen ; dev@dpdk.org; akhil.go...@nxp.com
> Cc: Richardson, Bruce
> Subject: RE: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add
> queue configuration
>
Thanks Rosen for your thorough code review. Some comments in-line below.
> From: Xu, Rosen
>
> Hi,
>
> Could you prefix all functions name with the FPGA IP name? FPGA is a very
> common device name.
>
I don't see such a guideline being used across all other PMDs.
Unsure it always help notab
hautru, Nicolas
>
> Subject: [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue
> configuration
>
> Adding function to create and configure queues for the device. Still no
> capability.
>
> Signed-off-by: Nicolas Chautru
> ---
> drivers/bas
Adding function to create and configure queues for
the device. Still no capability.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 441 -
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.h | 35 ++
2 files changed, 475 insertions(+),
6 matches
Mail list logo
