Hi Oliver,
>> I don't see any big changes in the v2 of that patch.
>>
>> At least both things that I have concerns about, stay unchanged in
>> the v2:
>>
>> 1) merge physaddr and buf_len in a bitfield - I still think we better
>> keep physaddr as 64bit field (PATCH 5).
>As nobody reacted
Hi Venky,
>> my testpmd iofwd test with the txqflags option disabling many mbuf
>> features is not representative of a real world application.
> [Venky] I did see your test reports. I also made the point that the
> tests we have are insufficient for testing the impact. If you look at
> data_ofs,
Hi Konstantin,
> I don't see any big changes in the v2 of that patch.
>
> At least both things that I have concerns about, stay unchanged in
> the v2:
>
> 1) merge physaddr and buf_len in a bitfield - I still think we better
> keep physaddr as 64bit field (PATCH 5).
As nobody reacted to ou
Hi Venky,
> It's because we haven't gotten to testing the patch yet, and figuring
> out all the problems. Putting it in and modifying MBUF needs a bit of
> time - one other option that I've looked at is to let the transmit
> offload parts (except for the VLAN) flow onto the second cache
> lin
Olivier,
>> It's because we haven't gotten to testing the patch yet, and figuring > out
>> all the problems. Putting it in and modifying MBUF needs a bit of > time -
>> one other option that I've looked at is to let the transmit > offload parts
>> (except for the VLAN) flow onto the second
Hi Thomas,
I don't see any big changes in the v2 of that patch.
At least both things that I have concerns about, stay unchanged in the v2:
1) merge physaddr and buf_len in a bitfield - I still think we better keep
physaddr as 64bit field (PATCH 5).
2) fix_tcp_phdr_cksum() is inside ixgbe TX funct
There were many comments on the first version of this serie,
and there is no comment on this second version.
So I understand everyone is OK with it and it can be applied in the git tree.
I'll wait 1 day more. Feel free to comment or acknowledge.
--
Thomas
Thomas,
It's because we haven't gotten to testing the patch yet, and figuring out all
the problems. Putting it in and modifying MBUF needs a bit of time - one other
option that I've looked at is to let the transmit offload parts (except for the
VLAN) flow onto the second cache line. That doesn
8 matches
Mail list logo
