Hi Thomas, I don't see any big changes in the v2 of that patch. At least both things that I have concerns about, stay unchanged in the v2: 1) merge physaddr and buf_len in a bitfield - I still think we better keep physaddr as 64bit field (PATCH 5). 2) fix_tcp_phdr_cksum() is inside ixgbe TX function, while I think it should be moved out of it to the upper layer (PATCH 11). Thanks Konstantin
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 22, 2014 4:02 PM To: Ananyev, Konstantin; Shaw, Jeffrey B; Richardson, Bruce; Venkatesan, Venky; nhorman at tuxdriver.com; stephen at networkplumber.org Cc: Olivier Matz; dev at dpdk.org Subject: Re: [PATCH v2 00/17] add TSO support There were many comments on the first version of this serie, and there is no comment on this second version. So I understand everyone is OK with it and it can be applied in the git tree. I'll wait 1 day more. Feel free to comment or acknowledge. -- Thomas
