On 06/17/2014 10:57 AM, Ananyev, Konstantin wrote:
> Yes, I understand that it will be initialised to 0 together with whole
> dev->data.
> But then, the condition:
> if (dev->data->min_rx_buf_size > mbp_buf_size)
> would never be true, and min_rx_buf_size would always remain 0?
> I thought you ne
>- Actually, looking at dev->data structure, there is something
>suspicious to me.
>From what I understood, secondary processes are not supposed to touch
>dev->data, at it is shared between processes.
>So I don't understand why rte_eth_dev_allocate() writes
>dev->data->port_id, without looking a
>As you konw, rte_ether.h is for ethernet definition
>(and should be located in librte_net).
>For RTE_IPV4_MIN_MTU, I think librte_net/rte_ip.h is more appropriate.
Yes, it is.
Konstantin
2014-06-17 08:57, Ananyev, Konstantin:
> >> 3) if ((mtu < 68) || (frame_size > dev_info.max_rx_pktlen))
> >> Can we add a new define for min allowable MTU (68) as it used in few
> >> places.
>
> >RTE_IPV4_MIN_MTU then ?
>
> Sounds good to me.
>
> >I am not sure where this belongs, it could go
Hello Konstantin,
On 06/16/2014 07:07 PM, Ananyev, Konstantin wrote:
>
> 1) [PATCH v2 3/7] ethdev: store min rx buffer size
> @@ -879,6 +879,8 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t
> rx_queue_id,
> const struct rte_eth_rxconf *rx_conf,
> s
Hi David,
>>
>> 1) [PATCH v2 3/7] ethdev: store min rx buffer size
>> @@ -879,6 +879,8 @@ rte_eth_rx_queue_setup(uint8_t port_id, uint16_t
>> rx_queue_id,
>> const struct rte_eth_rxconf *rx_conf,
>> struct rte_mempool *mp)
>> {
>> ...
>> +if (!ret) {
Hi David,
> This patchset introduces 3 new ethdev operations: flow control parameters
> retrieval and mtu get/set operations.
> Changes since v1:
> - compute min rx buffer size at ethdev level (to simplify pmd mtu checks)
> - introduce enable_scatter rx mode so that we can advise pmd to configure
This patchset introduces 3 new ethdev operations: flow control parameters
retrieval and mtu get/set operations.
Changes since v1:
- compute min rx buffer size at ethdev level (to simplify pmd mtu checks)
- introduce enable_scatter rx mode so that we can advise pmd to configure
scatter mode
- rew
8 matches
Mail list logo
