>- Actually, looking at dev->data structure, there is something >suspicious to me. >From what I understood, secondary processes are not supposed to touch >dev->data, at it is shared between processes. >So I don't understand why rte_eth_dev_allocate() writes >dev->data->port_id, without looking at process type.
It was a while since I looked at that part... But yes, it doesn't look right to me either. As I remember, primary and secondary processes supposed to have exactly the same device list. Probably that's why it was ok so far. >Idem, later in rte_eth_dev_init(), where >eth_dev->data->rx_mbuf_alloc_failed is set to 0 (which should already be >set to 0 anyway). >I think a cleanup is required here but it can wait until 1.7 is out. Yes, agree. >Plus, I am not sure we should let secondary processes use fdir calls, >change vlan offloads etc... >Ok, I spoke to Ivan and Thomas off-list. >I propose to add the following definition in rte_ether.h : >#define ETHER_MIN_MTU 68 >/**< Minimum MTU for IPv4 packets, see RFC 791. */ >What do you think of this ? That's fine too. Konstantin
