Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Lukasz Wojciechowski
W dniu 23.04.2020 o 18:14, Akhil Goyal pisze: > Hi Anoob, >> Hi Akhil, >> >> I have my concerns over unwanted checks in the datapath. Something that >> crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As >> Konstantin had suggested, PMDs (IXGBE here) could define a functio

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
Hi Anoob, > > Hi Akhil, > > I have my concerns over unwanted checks in the datapath. Something that > crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As > Konstantin had suggested, PMDs (IXGBE here) could define a function which > returns -ENOTSUP and it would have been

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Anoob Joseph
Hi Akhil, I have my concerns over unwanted checks in the datapath. Something that crypto enqueue/dequeue APIs are not doing is being enforced on other APIs. As Konstantin had suggested, PMDs (IXGBE here) could define a function which returns -ENOTSUP and it would have been win-win for everyone.

Re: [dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Akhil Goyal
> Valid checks for optional function pointers inside dev-ops > were disabled by undefined macro. > > Fixes: b6ee98547847 ("security: fix verification of parameters") > Cc: sta...@dpdk.org > > Signed-off-by: Konstantin Ananyev > --- Acked-by: Akhil Goyal Anoob, Do you have any concerns over

[dpdk-dev] [PATCH v2] security: fix crash at accessing non-implemented ops

2020-04-23 Thread Konstantin Ananyev
Valid checks for optional function pointers inside dev-ops were disabled by undefined macro. Fixes: b6ee98547847 ("security: fix verification of parameters") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.c | 9 ++--- 1 file changed, 6 insertions(