Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/19/2019 7:12 PM, Akhil Goyal wrote: > > On 3/11/2019 11:25 AM, Anoob Joseph wrote: >> The string compare to the length of driver name might give false >> positives when there are drivers with similar names (one being the >> subset of another). >> >> Following is such a naming which could res

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-19 Thread Akhil Goyal
On 3/11/2019 11:25 AM, Anoob Joseph wrote: > The string compare to the length of driver name might give false > positives when there are drivers with similar names (one being the > subset of another). > > Following is such a naming which could result in false positive. > 1. crypto_driver > 2. cry

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-18 Thread Anoob Joseph
Of Anoob Joseph > > Sent: Monday, March 11, 2019 5:56 AM > > To: Akhil Goyal ; Doherty, Declan > > ; De Lara Guarch, Pablo > > > > Cc: Anoob Joseph ; Ankur Dwivedi > > ; Jerin Jacob Kollanukkaran > > ; Narayana Prasad Raju Athreya > > ; Suheil Chandr

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-11 Thread Trahe, Fiona
aran ; Narayana Prasad Raju Athreya > ; Suheil > Chandran ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison > > The string compare to the length of driver name might give false > positives when there are drivers with similar names (one bein

[dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-10 Thread Anoob Joseph
The string compare to the length of driver name might give false positives when there are drivers with similar names (one being the subset of another). Following is such a naming which could result in false positive. 1. crypto_driver 2. crypto_driver1 When strncmp with len = strlen("crypto_driver