Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-18 Thread Honnappa Nagarahalli
e Capper ; > Phil Yang (Arm Technology China) ; Bruce Richardson > ; Konstantin Ananyev > > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > > On 9/14/2018 3:45 AM, Jerin Jacob wrote: > > -Original Message- > >> Date:

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-18 Thread Ferruh Yigit
quot; >> , Ferruh Yigit , "Jacob, Jerin" >> , "dev@dpdk.org" , nd >> , Steve Capper , "Phil Yang (Arm >> Technology China)" >> Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer >> synchronization >> >&g

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-13 Thread Jerin Jacob
t;dev@dpdk.org" , nd > , Steve Capper , "Phil Yang (Arm > Technology China)" > Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > > External Email > > -Original Message- > > Date: Thu, 13 Sep 2018 17:40:53

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-13 Thread Honnappa Nagarahalli
, "dev@dpdk.org" , > nd , Steve Capper , "Phil Yang (Arm > Technology China)" > Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > > > Hi Jerin, > Is there any reason for having 'RTE_RING_USE_C11_ME

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-13 Thread Jerin Jacob
quot;dev@dpdk.org" , nd > , Steve Capper , "Phil Yang (Arm > Technology China)" > Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > > > Hi Jerin, > Is there any reason for having 'RTE_RING_USE_C11_MEM_MOD

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-09-13 Thread Honnappa Nagarahalli
, Jerin" > , "dev@dpdk.org" , > nd , Steve Capper > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > user-agent: Microsoft-MacOutlook/10.10.0.180812 > > > There was a mention of rte_ring which is a different data structur

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-29 Thread Jerin Jacob
Date: Wed, 29 Aug 2018 07:34:34 + > > From: Ola Liljedahl > > To: "Kokkilagadda, Kiran" , Honnappa > > Nagarahalli , Gavin Hu > , > > Ferruh Yigit , "Jacob, Jerin" > > > > CC: "dev@dpdk.org" , nd

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-29 Thread Ola Liljedahl
halli , Gavin Hu , Ferruh Yigit , "Jacob, Jerin" > Cc: "dev@dpdk.org" , nd , Ola Liljedahl , Steve Capper > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization > > > Agreed. Please go a head and make the change

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-29 Thread Jerin Jacob
> > -- Ola > > From: "Kokkilagadda, Kiran" > Date: Wednesday, 29 August 2018 at 07:50 > To: Honnappa Nagarahalli , Gavin Hu > , Ferruh Yigit , "Jacob, Jerin" > > Cc: "dev@dpdk.org" , nd , Ola Liljedahl > , Steve Capper > Subject: Re

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-29 Thread Ola Liljedahl
rin" Cc: "dev@dpdk.org" , nd , Ola Liljedahl , Steve Capper Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization Agreed. Please go a head and make the changes. You need to make same change in kernel side also. And please use c11 ring (see rte_rin

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
nappa Nagarahalli Sent: Wednesday, August 29, 2018 10:29 AM To: Gavin Hu; Kokkilagadda, Kiran; Ferruh Yigit; Jacob, Jerin Cc: dev@dpdk.org; nd; Ola Liljedahl; Steve Capper Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization External Email I agree with Gavin here. Store to

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Honnappa Nagarahalli
l ; Steve Capper Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization Assuming reader and writer may execute on different CPU's, this become standard multithreaded programming. We are concerned about that update the reader pointer too early(weak ordering may reo

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Gavin Hu
___ From: Gavin Hu mailto:gavin...@arm.com>> Sent: Monday, August 27, 2018 9:10 PM To: Ferruh Yigit; Kokkilagadda, Kiran; Jacob, Jerin Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Honnappa Nagarahalli Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchro

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization In this instance there won't be any problem, as until the value of fifo->write changes, this loop won't get executed. As of now we didn't see any issue with it and for performance reasons, we don't wa

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
Gavin Hu Sent: Monday, August 27, 2018 9:10 PM To: Ferruh Yigit; Kokkilagadda, Kiran; Jacob, Jerin Cc: dev@dpdk.org; Honnappa Nagarahalli Subject: RE: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization External Email This fix is not complete, kni_fifo_get requires a read fence also,

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-27 Thread Gavin Hu
iumnetworks.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer > synchronization > > On 8/16/2018 10:55 AM, Kiran Kumar wrote: > > With existing code in kni_fifo_put, rx_q values are not being updated > > before updating fifo_writ

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-27 Thread Ferruh Yigit
On 8/16/2018 10:55 AM, Kiran Kumar wrote: > With existing code in kni_fifo_put, rx_q values are not being updated > before updating fifo_write. While reading rx_q in kni_net_rx_normal, > This is causing the sync issue on other core. So adding a write > barrier to make sure the values being synced b

[dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-16 Thread Kiran Kumar
With existing code in kni_fifo_put, rx_q values are not being updated before updating fifo_write. While reading rx_q in kni_net_rx_normal, This is causing the sync issue on other core. So adding a write barrier to make sure the values being synced before updating fifo_write. Fixes: 3fc5ca2f6352 ("