; To: Wang, Dong1 ; Lipiec, Herakliusz
> > ; dev@dpdk.org
> > Cc: tho...@monjalon.net; Burakov, Anatoly ;
> > sta...@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging
> > when using clone
> >
> >
> >
> > >
ta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging
> when using clone
>
>
>
> > -Original Message-
> > From: Wang, Dong1
> > Sent: Wednesday, November 14, 2018 11:06 AM
> > To: Ananyev, Konstantin ; Lipiec,
>
Acked-by: Wang Dong
-Original Message-
From: Ananyev, Konstantin
Sent: Tuesday, November 13, 2018 19:52
To: Lipiec, Herakliusz ; dev@dpdk.org
Cc: Wang, Dong1 ; tho...@monjalon.net; Burakov, Anatoly
; sta...@dpdk.org
Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when us
OK, understand now.
Thanks,
Dong
-Original Message-
From: Ananyev, Konstantin
Sent: Wednesday, November 14, 2018 19:19
To: Wang, Dong1 ; Lipiec, Herakliusz
; dev@dpdk.org
Cc: tho...@monjalon.net; Burakov, Anatoly ;
sta...@dpdk.org
Subject: RE: [PATCH v2] example/ipv4_multicast: fix app
> -Original Message-
> From: Wang, Dong1
> Sent: Wednesday, November 14, 2018 11:06 AM
> To: Ananyev, Konstantin ; Lipiec, Herakliusz
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; Burakov, Anatoly ;
> sta...@dpdk.org
> Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when
Hi Konstantin & Herakliusz,
In mcast_out_pkt(), new header added and to be the first segment. Driver will
check first segment's ol_flags when sending mbuf. So why new first segment
didn't inherit old one's ol_flags? This function already copied other mbuf
fields from old one.
Since this is an
Hi Dong,
I think that if a developer is to manipulate ol_flags, then its onto that
developer to take care of copying ol_flags .
Regards Herakliusz
> -Original Message-
> From: Wang, Dong1
> Sent: Wednesday, November 14, 2018 10:09 AM
> To: Ananyev, Konstantin ; Lipiec, Herakliusz
> ; dev@
>
> Hi Konstantin,
>
> In this example, no flags be set by user, so no need to copy flags from
> original mbuf.
Then why to bother?
> I'm thinking about some DPDK developers may create their own application
> based on this example, they add some flags before packet be
> cloned.
Hmm you r
Hi Konstantin,
In this example, no flags be set by user, so no need to copy flags from
original mbuf.
I'm thinking about some DPDK developers may create their own application based
on this example, they add some flags before packet be cloned.
Regards,
Dong
-Original Message-
From: An
Hi Dong,
> Hi Herakliusz,
>
> Since pkt->ol_flags might set some other bits except IND_ATTACHED_MBUF, how
> about set its value to original pkt->ol_flag
It could be done, but not sure what is the point?
Which flags you think we need to copy from cloned mbuf (segment #2) to new
header?
Konstant
Hi Herakliusz,
Since pkt->ol_flags might set some other bits except IND_ATTACHED_MBUF, how
about set its value to original pkt->ol_flags?
Regards,
Dong
-Original Message-
From: Lipiec, Herakliusz
Sent: Tuesday, November 13, 2018 19:49
To: dev@dpdk.org
Cc: Ananyev, Konstantin ; Wang, Do
> -Original Message-
> From: Lipiec, Herakliusz
> Sent: Tuesday, November 13, 2018 11:49 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin ; Wang, Dong1
> ; tho...@monjalon.net; Burakov,
> Anatoly ; Lipiec, Herakliusz
> ; sta...@dpdk.org
> Subject: [PATCH v2] example/ipv4_multicast: fix a
The ipv4_multicast sample application was dropping packets
when using mbuf clone. When creating an L2 header and copying
metadata from the source packet, the ol_flags were also copied
along with all the other metadata. Because the cloned packet
had IND_ATTACHED_MBUF flag set in its ol_flags,
this c
13 matches
Mail list logo
