Acked-by: Wang Dong <dong1.w...@intel.com> -----Original Message----- From: Ananyev, Konstantin Sent: Tuesday, November 13, 2018 19:52 To: Lipiec, Herakliusz <herakliusz.lip...@intel.com>; dev@dpdk.org Cc: Wang, Dong1 <dong1.w...@intel.com>; tho...@monjalon.net; Burakov, Anatoly <anatoly.bura...@intel.com>; sta...@dpdk.org Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when using clone
> -----Original Message----- > From: Lipiec, Herakliusz > Sent: Tuesday, November 13, 2018 11:49 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Wang, Dong1 > <dong1.w...@intel.com>; tho...@monjalon.net; Burakov, Anatoly > <anatoly.bura...@intel.com>; Lipiec, Herakliusz > <herakliusz.lip...@intel.com>; sta...@dpdk.org > Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using > clone > > The ipv4_multicast sample application was dropping packets when using > mbuf clone. When creating an L2 header and copying metadata from the > source packet, the ol_flags were also copied along with all the other > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in > its ol_flags, this caused the packets to never be freed when using > rte_pktmbuf_free. > Since copying ol_flags from the cloned packet is not necessary in the > first place, just don't do it. > > Fixes: af75078fece3 ("first public release") > CC: sta...@dpdk.org > > Reported-by: Wang Dong <dong1.w...@intel.com> > Signed-off-by: Herakliusz Lipiec <herakliusz.lip...@intel.com> > --- Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>