Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-11 Thread Thomas Monjalon
11/10/2017 15:09, Andrew Rybchenko: > On 10/11/2017 01:46 PM, Thomas Monjalon wrote: > > 11/10/2017 04:09, Ferruh Yigit: > >> On 10/11/2017 3:01 AM, Ferruh Yigit wrote: > >>> On 10/10/2017 9:20 PM, Matan Azrad wrote: > The stats_get dev op API doesn't include return value, so PMD cannot >

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-11 Thread Andrew Rybchenko
On 10/11/2017 01:46 PM, Thomas Monjalon wrote: 11/10/2017 04:09, Ferruh Yigit: On 10/11/2017 3:01 AM, Ferruh Yigit wrote: On 10/10/2017 9:20 PM, Matan Azrad wrote: The stats_get dev op API doesn't include return value, so PMD cannot return an error in case of failure at stats getting process t

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-11 Thread Thomas Monjalon
11/10/2017 04:09, Ferruh Yigit: > On 10/11/2017 3:01 AM, Ferruh Yigit wrote: > > On 10/10/2017 9:20 PM, Matan Azrad wrote: > >> The stats_get dev op API doesn't include return value, so PMD cannot > >> return an error in case of failure at stats getting process time. > >> > >> Since PCI devices can

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Ferruh Yigit
On 10/11/2017 3:01 AM, Ferruh Yigit wrote: > On 10/10/2017 9:20 PM, Matan Azrad wrote: >> The stats_get dev op API doesn't include return value, so PMD cannot >> return an error in case of failure at stats getting process time. >> >> Since PCI devices can be removed and there is a time between the

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 9:20 PM, Matan Azrad wrote: > The stats_get dev op API doesn't include return value, so PMD cannot > return an error in case of failure at stats getting process time. > > Since PCI devices can be removed and there is a time between the > physical removal to the RMV interrupt, the use

[dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Matan Azrad
The stats_get dev op API doesn't include return value, so PMD cannot return an error in case of failure at stats getting process time. Since PCI devices can be removed and there is a time between the physical removal to the RMV interrupt, the user may get invalid stats without any indication. Thi