11/10/2017 04:09, Ferruh Yigit:
> On 10/11/2017 3:01 AM, Ferruh Yigit wrote:
> > On 10/10/2017 9:20 PM, Matan Azrad wrote:
> >> The stats_get dev op API doesn't include return value, so PMD cannot
> >> return an error in case of failure at stats getting process time.
> >>
> >> Since PCI devices can be removed and there is a time between the
> >> physical removal to the RMV interrupt, the user may get invalid stats
> >> without any indication.
> >>
> >> This patch changes the stats_get API return value to be int instead of
> >> void.
> >>
> >> All the net PMDs stats_get dev ops are adjusted by this patch.
> >>
> >> Signed-off-by: Matan Azrad <ma...@mellanox.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
It is breaking compilation of tests:
test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types
initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct
rte_eth_stats *)')
with an expression of type 'void (struct rte_eth_dev *, struct
rte_eth_stats *)'
[-Wincompatible-pointer-types]
.stats_get = virtual_ethdev_stats_get,
