Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-06 Thread Yongseok Koh
> On May 3, 2019, at 3:13 PM, Dharmik Thakkar wrote: > > Hi Yongseok, > Thank you for the patch! I have tested it on Bluefield reference platform. It > works fine. Thanks for your testing. > One observation: > Even though I used 'make config T=arm64-bluefield-linuxapp-gcc’, > at the end of t

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Dharmik Thakkar
Hi Yongseok, Thank you for the patch! I have tested it on Bluefield reference platform. It works fine. One observation: Even though I used 'make config T=arm64-bluefield-linuxapp-gcc’, at the end of the build process it said 'Build complete [arm64-armv8a-linuxapp-gcc]’ Tested-by: Dharmik Thakk

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
On Fri, May 03, 2019 at 04:10:47PM +, Honnappa Nagarahalli wrote: > > > > Hi Yongseok, > > We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' > > (which would require a documentation change in [1]). > I enabled this and compiled, the compilation fails. Ideally (as discussed in > other

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Honnappa Nagarahalli
> > Hi Yongseok, > We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' > (which would require a documentation change in [1]). I enabled this and compiled, the compilation fails. Ideally (as discussed in other threads), the PMD code itself does not make use of the crypto instructions, so

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 3, 2019 5:58 PM > To: Jerin Jacob Kollanukkaran ; tho...@monjalon.net > Cc: dev@dpdk.org; bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula > ; shah...@mellanox.com; gavin...@arm.com; > honnappa.nagaraha...@arm.com; sta...

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Honnappa Nagarahalli
Hi Yongseok, We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' (which would require a documentation change in [1]). I think this change might have an impact on the existing users. Does this change need to be documented somewhere (at least in the release notes)? [1] https://doc.dpdk

[dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. It is known that not all the armv8 platforms have the crypto extension. For example, Mellanox B