> -----Original Message----- > From: Yongseok Koh <ys...@mellanox.com> > Sent: Friday, May 3, 2019 5:58 PM > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; tho...@monjalon.net > Cc: dev@dpdk.org; bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula > <pbhagavat...@marvell.com>; shah...@mellanox.com; gavin...@arm.com; > honnappa.nagaraha...@arm.com; sta...@dpdk.org > Subject: [EXT] [PATCH v2] build: disable armv8 crypto extension > > Per armv8 crypto extension support, make build always enable it by default > > as > long as compiler supports the feature while meson build only enables it for > 'default' machine of generic armv8 architecture. > > It is known that not all the armv8 platforms have the crypto extension. For > example, Mellanox BlueField has a variant which doesn't have it. If crypto > enabled binary runs on such a platform, rte_eal_init() fails. > > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will > generate the crypto instructions only when crypto intrinsics are used. > For the devices supporting 8.2 crypto or newer, compiler could generate such > instructions beyond intrinsics or asm code. For example, compiler can generate > 3-way exclusive OR instructions if sha3 is supported. However, it has to be > enabled by adding '+sha3' as of today. > > In DPDK, armv8 cryptodev is the only one which requires the crypto support. > As it even uses external library of Marvell which is compiled out of DPDK with > crypto support and there's run-time check for required cpuflags, crypto > support > can be disabled in DPDK. > > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh <ys...@mellanox.com> > ---
Acked-by: Jerin Jacob <jer...@marvell.com>
