Re: [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD

2019-10-29 Thread Andrew Rybchenko
: Re: [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD Hi Pavan, thanks for the patch. Please, see my review notes below. On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Some PMD can't work when certain offloads are disable

Re: [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD

2019-10-29 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Andrew Rybchenko >Sent: Tuesday, October 29, 2019 12:36 PM >To: Pavan Nikhilesh Bhagavatula ; >ferruh.yi...@intel.com; Jerin Jacob Kollanukkaran >; Thomas Monjalon >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD

2019-10-29 Thread Andrew Rybchenko
Hi Pavan, thanks for the patch. Please, see my review notes below. On 10/29/19 8:03 AM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Some PMD can't work when certain offloads are disabled, to work around this the PMD auto enable the offloads internally and expose it through dev->data

[dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD

2019-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Some PMD can't work when certain offloads are disabled, to work around this the PMD auto enable the offloads internally and expose it through dev->data->dev_conf.rxmode.offloads. After dev_configure is called compare the requested offloads to the enabled offloads and log any