Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-27 Thread Varghese, Vipin
HI > > > +/**< Enable port debug. */ > In comment , Enable displaying port info? ok > > > +static uint32_t enable_dbg_port; > Do you want to consider replacing "debug" to "show" in code here other > places? As you have already changed the commands to "show." > If the variable naming has to

Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > +/**< Enable port debug. */ In comment , Enable displaying port info? > +static uint32_t enable_dbg_port; Do you want to consider replacing "debug" to "show" in code here other places? As you have already changed the commands to "show."

[dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-23 Thread Vipin Varghese
Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 92854f5ba..5505d3fe3 100644 --