Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-07 Thread Ophir Munk
> Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file > for libabigail > > 06/05/2020 16:15, Ray Kinsella: > > > > On 06/05/2020 13:52, Thomas Monjalon wrote: > > > 06/05/2020 14:42, David Marchand: > > >> On Wed, May 6, 2020

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-06 Thread Thomas Monjalon
06/05/2020 16:15, Ray Kinsella: > > On 06/05/2020 13:52, Thomas Monjalon wrote: > > 06/05/2020 14:42, David Marchand: > >> On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: > >>> > >>> 05/05/2020 16:53, David Marchand: > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > +; These

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-06 Thread Ray Kinsella
On 06/05/2020 13:52, Thomas Monjalon wrote: > 06/05/2020 14:42, David Marchand: >> On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: >>> >>> 05/05/2020 16:53, David Marchand: On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > +; These functions were moved from stable to internal.

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-06 Thread Thomas Monjalon
06/05/2020 14:42, David Marchand: > On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: > > > > 05/05/2020 16:53, David Marchand: > > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > > > +; These functions were moved from stable to internal. > > > > +; This is a temporary exception till D

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-06 Thread David Marchand
On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: > > 05/05/2020 16:53, David Marchand: > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > > +; These functions were moved from stable to internal. > > > +; This is a temporary exception till DPDK 20.11. > > > > This is not until 20.11 if

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-06 Thread Thomas Monjalon
05/05/2020 16:53, David Marchand: > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > +; These functions were moved from stable to internal. > > +; This is a temporary exception till DPDK 20.11. > > This is not until 20.11 if we merge this patch now. > It is only when comparing 20.02 to 20.05.

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-05 Thread Ray Kinsella
On 05/05/2020 15:53, David Marchand wrote: > Don't forget to Cc: Ray. > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: >> >> Create file libabigail.internalignore where it is specified to ignore >> all symbols in library file librte_pmd_mlx.* during an ABI check. > > I don't like the sepa

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-05 Thread David Marchand
Don't forget to Cc: Ray. On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > Create file libabigail.internalignore where it is specified to ignore > all symbols in library file librte_pmd_mlx.* during an ABI check. I don't like the separate file, having rules with comments in a single place is

Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-05 Thread Matan Azrad
From: Ophir Munk > Create file libabigail.internalignore where it is specified to ignore all > symbols > in library file librte_pmd_mlx.* during an ABI check. > > Signed-off-by: Ophir Munk Acked-by: Matan Azrad

[dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail

2020-05-05 Thread Ophir Munk
Create file libabigail.internalignore where it is specified to ignore all symbols in library file librte_pmd_mlx.* during an ABI check. Signed-off-by: Ophir Munk --- devtools/check-abi.sh | 4 +++- devtools/libabigail.internalignore | 4 2 files changed, 7 insertions(+), 1 dele