Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-12 Thread Varghese, Vipin
Hi Reshma, I tried your suggestion, but the build fails even using warning or not using warning. The reason is DPDK build expects pdump to be build. I am looking at other alternatives, how to get this done. In last effort, we may need to disable PDUMP to be build default from '.config' file. T

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-06 Thread Pattan, Reshma
> > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) > +$(error "Please enable CONFIG_RTE_LIBRTE_PMD_PCAP") endif > + How about combining If(($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) check with below existing if check? with this, dpdk-pdump will be compiled only when both the flags are enabled. > ifeq ($(CONFI

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-06 Thread Ferruh Yigit
On 3/6/2018 8:45 AM, Varghese, Vipin wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, March 5, 2018 2:33 PM >> To: Varghese, Vipin ; dev@dpdk.org; Pattan, >> Reshma >> Cc: Mcnamara, John >> Subject: Re

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-06 Thread Varghese, Vipin
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, March 5, 2018 2:33 PM > To: Varghese, Vipin ; dev@dpdk.org; Pattan, > Reshma > Cc: Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD > > On 3/5/2018 7:

Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-05 Thread Ferruh Yigit
On 3/5/2018 7:57 AM, Vipin Varghese wrote: > dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to > the device-queue pair. Updating Makefile to check for the same. > > Signed-off-by: Vipin Varghese > --- > app/pdump/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --

[dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD

2018-03-05 Thread Vipin Varghese
dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to the device-queue pair. Updating Makefile to check for the same. Signed-off-by: Vipin Varghese --- app/pdump/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/app/pdump/Makefile b/app/pdump/Makefile index bd3c208..