On 3/5/2018 7:57 AM, Vipin Varghese wrote: > dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to > the device-queue pair. Updating Makefile to check for the same. > > Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com> > --- > app/pdump/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/app/pdump/Makefile b/app/pdump/Makefile > index bd3c208..038a34f 100644 > --- a/app/pdump/Makefile > +++ b/app/pdump/Makefile > @@ -3,6 +3,10 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) > +$(error "Please enable CONFIG_RTE_LIBRTE_PMD_PCAP") > +endif
pdump is enabled default, so won't this break the default build? What about moving this to lib/librte_pdump, convert $(error ..) to $(warning ..) and disable CONFIG_RTE_LIBRTE_PDUMP there? > + > ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y) > > APP = dpdk-pdump >
