Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-17 Thread Jason Wang
On 2020/5/18 上午11:09, Wang, Xiao W wrote: Hi, Comments inline. Best Regards, Xiao -Original Message- From: Jason Wang Sent: Friday, May 15, 2020 6:09 PM To: Wang, Xiao W; Maxime Coquelin ; Ye, Xiaolong; shah...@mellanox.com;ma...@mellanox.com;amore...@redhat.com; viachesl...@mellano

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-17 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 6:09 PM > To: Wang, Xiao W ; Maxime Coquelin > ; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; amore...@redhat.com; > viachesl...@mellanox.com; dev@dpdk.org > Cc: l.

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/15 下午5:42, Wang, Xiao W wrote: Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/15 下午5:42, Wang, Xiao W wrote: Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Wang, Xiao W
Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@mellanox.com; dev@dpdk.org > Cc: l...@red

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/14 下午4:02, Maxime Coquelin wrote: This patch adds support to enabling and disabling vrings on a per-vring granularity. Signed-off-by: Maxime Coquelin A question here, I see in qemu peer_attach() may try to generate VHOST_USER_SET_VRING_ENABLE, but just from the name I think it s

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Ye Xiaolong
On 05/14, Maxime Coquelin wrote: >This patch adds support to enabling and disabling >vrings on a per-vring granularity. > >Signed-off-by: Maxime Coquelin >--- > drivers/vdpa/ifc/base/ifcvf.c | 9 + > drivers/vdpa/ifc/base/ifcvf.h | 4 > drivers/vdpa/ifc/ifcvf_vdpa.c | 23 +

[dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-14 Thread Maxime Coquelin
This patch adds support to enabling and disabling vrings on a per-vring granularity. Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.c | 9 + drivers/vdpa/ifc/base/ifcvf.h | 4 drivers/vdpa/ifc/ifcvf_vdpa.c | 23 ++- 3 files changed, 35 insertion