[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-22 Thread Thomas Monjalon
2016-03-01 13:02, Panu Matilainen: > On 02/26/2016 03:13 PM, Aaron Conole wrote: > > "Lu, Wenzhuo" writes: > >> Normally we will not maintain the base code. It's just taken from kernel > >> driver. > >> Agree with you that the whitespace is misleading. But as it's no real > >> impact. I'd like to

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-18 Thread Zhang, Helin
> -Original Message- > From: Aaron Conole [mailto:aconole at redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev at dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Helin > ; Ananyev, Konstantin > ; Richardson, Bruce > > Subject: [PATCH 3/8] drivers/net/e1000: Fix missing brackets > > Th

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-03-01 Thread Panu Matilainen
On 02/26/2016 03:13 PM, Aaron Conole wrote: > Hi Wenzhou, > > "Lu, Wenzhuo" writes: > >> Hi Aaron, >> >> >>> -Original Message- >>> From: Aaron Conole [mailto:aconole at redhat.com] >>> Sent: Friday, February 26, 2016 2:49 AM >>> To: dev at dpdk.org >>> Cc: Lu, Wenzhuo; Zhang, Helin; Anany

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-02-26 Thread Aaron Conole
Hi Wenzhou, "Lu, Wenzhuo" writes: > Hi Aaron, > > >> -Original Message- >> From: Aaron Conole [mailto:aconole at redhat.com] >> Sent: Friday, February 26, 2016 2:49 AM >> To: dev at dpdk.org >> Cc: Lu, Wenzhuo; Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce >> Subject: [PATCH 3/8]

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-02-26 Thread Lu, Wenzhuo
Hi Aaron, > -Original Message- > From: Aaron Conole [mailto:aconole at redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev at dpdk.org > Cc: Lu, Wenzhuo; Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce > Subject: [PATCH 3/8] drivers/net/e1000: Fix missing brackets > > Th

[dpdk-dev] [PATCH 3/8] drivers/net/e1000: Fix missing brackets

2016-02-25 Thread Aaron Conole
The register read/write mphy functions have misleading whitespace around the locked check. This cleanup merely preserves the existing functionality while improving the ready check. Signed-off-by: Aaron Conole --- drivers/net/e1000/base/e1000_phy.c | 12 ++-- 1 file changed, 6 insertions(