Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-30 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote: >> On Fri, 27 Jan 2017 09:56:53 -0500 >> Aaron Conole wrote: >> >> > + if (rte_eal_alarm_init() < 0) { >> > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); >> > + /*

Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Bruce Richardson
On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 09:56:53 -0500 > Aaron Conole wrote: > > > + if (rte_eal_alarm_init() < 0) { > > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > > + /* rte_eal_alarm_init sets rte_err

Re: [dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 09:56:53 -0500 Aaron Conole wrote: > + if (rte_eal_alarm_init() < 0) { > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n"); > + /* rte_eal_alarm_init sets rte_errno on failure. */ > + errno = rte_errno; Hmm. DPDK in genera

[dpdk-dev] [PATCH 15/25] eal: do not panic on alarm init

2017-01-27 Thread Aaron Conole
rte_eal_alarm_init() call uses the linux timerfd framework to create a poll()-able timer using standard posix file operations. This could fail for a few reasons given in the man-pages, but many could be corrected by the user application. No need to panic. Signed-off-by: Aaron Conole --- lib/li