Bruce Richardson <bruce.richard...@intel.com> writes:
> On Fri, Jan 27, 2017 at 08:31:55AM -0800, Stephen Hemminger wrote:
>> On Fri, 27 Jan 2017 09:56:53 -0500
>> Aaron Conole <acon...@redhat.com> wrote:
>>
>> > + if (rte_eal_alarm_init() < 0) {
>> > + RTE_LOG (ERR, EAL, "Cannot init interrupt-handling thread\n");
>> > + /* rte_eal_alarm_init sets rte_errno on failure. */
>> > + errno = rte_errno;
>>
>> Hmm. DPDK in general does not reset errno but instead uses error code
>> directly on return (best) or in some cases rte_errno
>
> I think we'll disagree on what way of returning error codes is best :-), but
> yes, DPDK does not generally modify errno.
Okay, I'll drop the errno set. I think it's a mistake from the first
version of the series (as RFC).
Thanks for the reviews, Bruce and Stephen!
