Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-06-08 Thread Andrew Rybchenko
On 3/15/21 10:27 PM, Stephen Hemminger wrote: > Posix mutex are not by default safe for protecting for usage > from multiple processes. The flow ops mutex could be used by > both primary and secondary processes. > > Bugzilla ID: 662 > Signed-off-by: Stephen Hemminger > Fixes: 80d1a9aff7f6 ("ethde

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-19 Thread Thomas Monjalon
19/04/2021 19:45, Stephen Hemminger: > On Mon, 19 Apr 2021 19:14:08 +0200 > Thomas Monjalon wrote: > > The compilation fails on MinGW: > > error: implicit declaration of function ‘pthread_mutexattr_init’ > > Sorry, don't have all the variants. How do you handle the lack of > compatibility on Wind

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-19 Thread Stephen Hemminger
On Mon, 19 Apr 2021 19:14:08 +0200 Thomas Monjalon wrote: > About the title, better to say "multi-process" and do not > commit on being completely safe for the whole API. > It is just fixing the mutex for multi-process, > and this mutex is for driver not being natively multi-thread. > > The comp

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-19 Thread Thomas Monjalon
About the title, better to say "multi-process" and do not commit on being completely safe for the whole API. It is just fixing the mutex for multi-process, and this mutex is for driver not being natively multi-thread. The compilation fails on MinGW: error: implicit declaration of function ‘pthread

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-16 Thread Ferruh Yigit
On 3/15/2021 7:27 PM, Stephen Hemminger wrote: Posix mutex are not by default safe for protecting for usage from multiple processes. The flow ops mutex could be used by both primary and secondary processes. Bugzilla ID: 662 Signed-off-by: Stephen Hemminger Fixes: 80d1a9aff7f6 ("ethdev: make flo

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 2:41 AM, fengchengwen wrote: We make a test on this patch, test result show that it works fine. Below is the detail: HW: Kunpeng920 ARM Platform which is ARMv8 NIC: Kunpeng920 SOC NIC OS: Linux centos-C3 5.12.0-rc4+ DPDK: 21.02 DRV: hns3 Start three process: ./testpmd -w :bd:0

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-16 Thread Ajit Khaparde
; Ori Kam ; > >> Andrew Rybchenko ; NBU-Contact-Thomas > >> Monjalon > >> Cc: dev@dpdk.org; Stephen Hemminger > >> Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary > >> process safe > >> > >> On 3/16/2021 1

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-15 Thread fengchengwen
We make a test on this patch, test result show that it works fine. Below is the detail: HW: Kunpeng920 ARM Platform which is ARMv8 NIC: Kunpeng920 SOC NIC OS: Linux centos-C3 5.12.0-rc4+ DPDK: 21.02 DRV: hns3 Start three process: ./testpmd -w :bd:00.0 -l 67-68 --proc-type=auto -- -i --num-pr

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-15 Thread Suanming Mou
nath Kotur > > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary > process safe > > On 4/15/2021 3:55 AM, Suanming Mou wrote: > > Hi, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Wednesda

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-15 Thread Stephen Hemminger
On Thu, 15 Apr 2021 08:42:39 +0100 Ferruh Yigit wrote: > > (If I understand correctly, mlx PMD level now should support multi-process, > > but better to have the confirmation from maintainers with much deeper > > level). > > I assume this patch solves the posix mutex for multi-process only, har

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-15 Thread Ferruh Yigit
: make flow API primary/secondary process safe On 3/16/2021 11:48 PM, Suanming Mou wrote: Hi Stephen, -Original Message- From: Stephen Hemminger Sent: Tuesday, March 16, 2021 3:27 AM To: dev@dpdk.org Cc: Stephen Hemminger ; Suanming Mou Subject: [PATCH 1/2] ethdev: make flow API primary

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-14 Thread Stephen Hemminger
n > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary > > process safe > > > > On 3/16/2021 11:48 PM, Suanming Mou wrote: > > > Hi Stephen, > > > > > >> -Original Me

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-14 Thread Suanming Mou
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 14, 2021 9:07 PM > To: Suanming Mou ; Ori Kam ; > Andrew Rybchenko ; NBU-Contact-Thomas > Monjalon > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make fl

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-14 Thread Ferruh Yigit
On 3/16/2021 11:48 PM, Suanming Mou wrote: Hi Stephen, -Original Message- From: Stephen Hemminger Sent: Tuesday, March 16, 2021 3:27 AM To: dev@dpdk.org Cc: Stephen Hemminger ; Suanming Mou Subject: [PATCH 1/2] ethdev: make flow API primary/secondary process safe Posix mutex are not

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-03-16 Thread Suanming Mou
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, March 17, 2021 8:14 AM > To: Suanming Mou > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] ethdev: make flow API primary/secondary process safe > > On Tue, 16 Mar 2021 23:48:57 + > Suanming Mou wrote: > > > Hi Stephe

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-03-16 Thread Stephen Hemminger
On Tue, 16 Mar 2021 23:48:57 + Suanming Mou wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, March 16, 2021 3:27 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Suanming Mou > > > > Subject: [PATCH 1/2] ethdev: make flow API primary/s

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-03-16 Thread Suanming Mou
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, March 16, 2021 3:27 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Suanming Mou > > Subject: [PATCH 1/2] ethdev: make flow API primary/secondary process safe > > Posix mutex are not by default safe for protecti

[dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-03-15 Thread Stephen Hemminger
Posix mutex are not by default safe for protecting for usage from multiple processes. The flow ops mutex could be used by both primary and secondary processes. Bugzilla ID: 662 Signed-off-by: Stephen Hemminger Fixes: 80d1a9aff7f6 ("ethdev: make flow API thread safe") Cc: suanmi...@nvidia.com ---