Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2020 10:12:46 +0100 Bruce Richardson wrote: > On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > > 24/09/2020 00:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 23:52:07 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > Yes it is a step in the right di

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-24 Thread Ferruh Yigit
On 9/24/2020 11:07 AM, Thomas Monjalon wrote: 24/09/2020 11:12, Bruce Richardson: On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: 24/09/2020 00:02, Stephen Hemminger: On Wed, 23 Sep 2020 23:52:07 +0200 Thomas Monjalon wrote: Yes it is a step in the right direction. Changing

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-24 Thread Thomas Monjalon
24/09/2020 11:12, Bruce Richardson: > On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > > 24/09/2020 00:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 23:52:07 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > Yes it is a step in the right direction. > > > > > > > > Chan

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-24 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 12:35:58AM +0200, Thomas Monjalon wrote: > 24/09/2020 00:02, Stephen Hemminger: > > On Wed, 23 Sep 2020 23:52:07 +0200 > > Thomas Monjalon wrote: > > > > > > > > > Yes it is a step in the right direction. > > > > > > > Changing the API means adding some error checks in eve

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
24/09/2020 00:02, Stephen Hemminger: > On Wed, 23 Sep 2020 23:52:07 +0200 > Thomas Monjalon wrote: > > > > > > > Yes it is a step in the right direction. > > > > > > Changing the API means adding some error checks in every apps. > > > > > > The reason for not doing is that I did not commit for th

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 23:52:07 +0200 Thomas Monjalon wrote: > > > > > Yes it is a step in the right direction. > > > > > Changing the API means adding some error checks in every apps. > > > > > The reason for not doing is that I did not commit for this task, > > > > > and I am not the author of the

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 23:47, Stephen Hemminger: > On Wed, 23 Sep 2020 23:06:42 +0200 > Thomas Monjalon wrote: > > > 23/09/2020 23:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 22:53:46 +0200 > > > Thomas Monjalon wrote: > > > > 23/09/2020 18:41, Ferruh Yigit: > > > > > On 9/13/2020 11:06 PM, Thomas

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 23:06:42 +0200 Thomas Monjalon wrote: > 23/09/2020 23:02, Stephen Hemminger: > > On Wed, 23 Sep 2020 22:53:46 +0200 > > Thomas Monjalon wrote: > > > 23/09/2020 18:41, Ferruh Yigit: > > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > > The device operation .d

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 23:02, Stephen Hemminger: > On Wed, 23 Sep 2020 22:53:46 +0200 > Thomas Monjalon wrote: > > 23/09/2020 18:41, Ferruh Yigit: > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > The device operation .dev_close was returning void. > > > > This driver interface is changed to retur

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 22:53:46 +0200 Thomas Monjalon wrote: > 23/09/2020 18:41, Ferruh Yigit: > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > The device operation .dev_close was returning void. > > > This driver interface is changed to return an int. > > > > > > Note that the API rte_eth

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:41, Ferruh Yigit: > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > The device operation .dev_close was returning void. > > This driver interface is changed to return an int. > > > > Note that the API rte_eth_dev_close() is still returning void, > > although a deprecation notice is

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Ferruh Yigit
On 9/13/2020 11:06 PM, Thomas Monjalon wrote: The device operation .dev_close was returning void. This driver interface is changed to return an int. Note that the API rte_eth_dev_close() is still returning void, although a deprecation notice is pending to change it as well. Why not update the

[dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-13 Thread Thomas Monjalon
The device operation .dev_close was returning void. This driver interface is changed to return an int. Note that the API rte_eth_dev_close() is still returning void, although a deprecation notice is pending to change it as well. Signed-off-by: Thomas Monjalon --- app/test/virtual_pmd.c