23/09/2020 23:47, Stephen Hemminger: > On Wed, 23 Sep 2020 23:06:42 +0200 > Thomas Monjalon <tho...@monjalon.net> wrote: > > > 23/09/2020 23:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 22:53:46 +0200 > > > Thomas Monjalon <tho...@monjalon.net> wrote: > > > > 23/09/2020 18:41, Ferruh Yigit: > > > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > > > The device operation .dev_close was returning void. > > > > > > This driver interface is changed to return an int. > > > > > > > > > > > > Note that the API rte_eth_dev_close() is still returning void, > > > > > > although a deprecation notice is pending to change it as well. > > > > > > > > > > Why not update the 'rte_eth_dev_close()' in this patch? After the > > > > > updates below it should be easier. > > > > > > > > Yes it is a step in the right direction. > > > > Changing the API means adding some error checks in every apps. > > > > The reason for not doing is that I did not commit for this task, > > > > and I am not the author of the deprecation notice. > > > > We can discuss how to follow up once this series is merged. > > > > > > Not sure what application can really do if dev_close fails other than > > > call rte_exit()? > > > > At least, it can show a message to the user. > > Agree, but no code checks return from close() system call now. > At least testpmd should be updated; the examples are fine.
How do you explicitly silence the static code analyzers? Do you recommend adding (void) in front of the call to close()?
