[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-30 Thread Yuanhan Liu
On Mon, May 30, 2016 at 02:40:00AM +, Xie, Huawei wrote: > On 5/27/2016 5:06 PM, Yuanhan Liu wrote: > > On Tue, May 24, 2016 at 09:38:32PM +0800, Huawei Xie wrote: > >>vq->vq_ring_mem = mz->phys_addr; > >>vq->vq_ring_virt_mem = mz->addr; > >> - PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem:

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-30 Thread Xie, Huawei
On 5/30/2016 11:00 AM, Yuanhan Liu wrote: > On Mon, May 30, 2016 at 02:40:00AM +, Xie, Huawei wrote: >> On 5/27/2016 5:06 PM, Yuanhan Liu wrote: >>> On Tue, May 24, 2016 at 09:38:32PM +0800, Huawei Xie wrote: vq->vq_ring_mem = mz->phys_addr; vq->vq_ring_virt_mem = mz->addr;

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-30 Thread Xie, Huawei
On 5/27/2016 5:06 PM, Yuanhan Liu wrote: > On Tue, May 24, 2016 at 09:38:32PM +0800, Huawei Xie wrote: >> vq->vq_ring_mem = mz->phys_addr; >> vq->vq_ring_virt_mem = mz->addr; >> -PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem: 0x%"PRIx64, >> (uint64_t)mz->phys_addr); >> -PMD_INIT_LOG(

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-27 Thread Yuanhan Liu
On Tue, May 24, 2016 at 09:38:32PM +0800, Huawei Xie wrote: > vq->vq_ring_mem = mz->phys_addr; > vq->vq_ring_virt_mem = mz->addr; > - PMD_INIT_LOG(DEBUG, "vq->vq_ring_mem: 0x%"PRIx64, > (uint64_t)mz->phys_addr); > - PMD_INIT_LOG(DEBUG, "vq->vq_ring_virt_mem: 0x%"PRIx64, >

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-25 Thread Xie, Huawei
On 5/25/2016 6:08 PM, Thomas Monjalon wrote: > Is it a v2? There is neither changelog nor v2 in the title. Yes, forget to add v2. Mainly rebase against Yuanhan's tree. Besides, to make the patch simple and focused, use the old queue setup.

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-25 Thread Thomas Monjalon
2016-05-24 21:38, Huawei Xie: > We keep a common vq structure, containing only vq related fields, > and then split others into RX, TX and control queue respectively. > > Signed-off-by: Huawei Xie Is it a v2? There is neither changelog nor v2 in the title.

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-24 Thread Huawei Xie
We keep a common vq structure, containing only vq related fields, and then split others into RX, TX and control queue respectively. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.c | 352 ++-- drivers/net/virtio/virtio_ethdev.h | 2 +- driv

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-09 Thread Yuanhan Liu
On Mon, May 09, 2016 at 05:44:03AM +, Xie, Huawei wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Monday, May 09, 2016 1:15 PM > > To: Xie, Huawei > > Cc: dev at dpdk.org > > Sub

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-09 Thread Xie, Huawei
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, May 09, 2016 1:15 PM > To: Xie, Huawei > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue > > On Thu, May 05, 2016 at 05:29

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-08 Thread Yuanhan Liu
On Thu, May 05, 2016 at 05:29:27AM +, Xie, Huawei wrote: > What I mean is firstly we split the queue, without breaking the common > setup; then introduce RX/TX specific setup calling extracted common > setup, so we don't have a chance to introduce duplicated code. In such way, you have actuall

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-05 Thread Xie, Huawei
On 5/5/2016 11:46 AM, Yuanhan Liu wrote: > On Thu, May 05, 2016 at 03:29:44AM +, Xie, Huawei wrote: >> On 5/5/2016 11:03 AM, Yuanhan Liu wrote: >>> On Thu, May 05, 2016 at 01:54:25AM +, Xie, Huawei wrote: On 5/5/2016 7:59 AM, Yuanhan Liu wrote: > On Wed, May 04, 2016 at 08:50:27AM

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-05 Thread Xie, Huawei
On 5/5/2016 11:03 AM, Yuanhan Liu wrote: > On Thu, May 05, 2016 at 01:54:25AM +, Xie, Huawei wrote: >> On 5/5/2016 7:59 AM, Yuanhan Liu wrote: >>> On Wed, May 04, 2016 at 08:50:27AM +0800, Huawei Xie wrote: -int virtio_dev_queue_setup(struct rte_eth_dev *dev, - int qu

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-05 Thread Xie, Huawei
On 5/5/2016 7:59 AM, Yuanhan Liu wrote: > On Wed, May 04, 2016 at 08:50:27AM +0800, Huawei Xie wrote: >> -int virtio_dev_queue_setup(struct rte_eth_dev *dev, >> -int queue_type, >> -uint16_t queue_idx, >> +static int >> +virtio_dev_cq_queue_setup(struct rte_e

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-04 Thread Yuanhan Liu
On Thu, May 05, 2016 at 03:29:44AM +, Xie, Huawei wrote: > On 5/5/2016 11:03 AM, Yuanhan Liu wrote: > > On Thu, May 05, 2016 at 01:54:25AM +, Xie, Huawei wrote: > >> On 5/5/2016 7:59 AM, Yuanhan Liu wrote: > >>> On Wed, May 04, 2016 at 08:50:27AM +0800, Huawei Xie wrote: > -int virtio_

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-04 Thread Yuanhan Liu
On Thu, May 05, 2016 at 01:54:25AM +, Xie, Huawei wrote: > On 5/5/2016 7:59 AM, Yuanhan Liu wrote: > > On Wed, May 04, 2016 at 08:50:27AM +0800, Huawei Xie wrote: > >> -int virtio_dev_queue_setup(struct rte_eth_dev *dev, > >> - int queue_type, > >> - uint16_t q

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-04 Thread Yuanhan Liu
On Wed, May 04, 2016 at 08:50:27AM +0800, Huawei Xie wrote: > -int virtio_dev_queue_setup(struct rte_eth_dev *dev, > - int queue_type, > - uint16_t queue_idx, > +static int > +virtio_dev_cq_queue_setup(struct rte_eth_dev *dev, While it's good to split Rx/Tx

[dpdk-dev] [PATCH] virtio: split virtio rx/tx queue

2016-05-04 Thread Huawei Xie
Currently virtio RX/TX paths use common vq structure. The initial idea is to split virtio RX and TX queues completely as they have different memory requirement and we could arrange data friendly for optimization for different paths in future. With this patch, we keep a common vq structure, as we h