On Mon, May 09, 2016 at 05:44:03AM +0000, Xie, Huawei wrote:
>
>
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> > Sent: Monday, May 09, 2016 1:15 PM
> > To: Xie, Huawei
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] virtio: split virtio rx/tx queue
> >
> > On Thu, May 05, 2016 at 05:29:27AM +0000, Xie, Huawei wrote:
> > > What I mean is firstly we split the queue, without breaking the common
> > > setup; then introduce RX/TX specific setup calling extracted common
> > > setup, so we don't have a chance to introduce duplicated code.
> >
> > In such way, you have actually introduced duplicated code, haven't you?
> > You may argue, "yes, but I will fix it in a later patch." This is to
> > introducing a build error and fixing it later to me.
> >
>
> Yuanhan, I don't see how hard it is to understand this. Duplicated code isn't
> introduced. I will send the patch later.
Good. I just want to make sure no duplicated code is introduced.
--yliu
