[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-14 Thread Thomas Monjalon
2016-03-10 08:43, David Marchand: > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > wrote: > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > a random upper 32 bit feature bits, as the following io port read reads > > lower 32 bit only. It could lead a feature bits tha

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-14 Thread Yuanhan Liu
On Mon, Mar 14, 2016 at 10:48:31AM +, Bruce Richardson wrote: > On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote: > > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote: > > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > > > wrote: > > > > Declare dst as type uint32_t

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-14 Thread Bruce Richardson
On Mon, Mar 14, 2016 at 08:44:32PM +0800, Yuanhan Liu wrote: > On Mon, Mar 14, 2016 at 10:48:31AM +, Bruce Richardson wrote: > > On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote: > > > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote: > > > > On Thu, Mar 10, 2016 at 8:0

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-14 Thread Bruce Richardson
On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote: > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote: > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > > wrote: > > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > > a random upper 32 bit feat

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-10 Thread Yuanhan Liu
On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote: > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > wrote: > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > a random upper 32 bit feature bits, as the following io port read reads > > lower 32 bit only. It

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-10 Thread Tan, Jianfeng
On 3/10/2016 3:01 PM, Yuanhan Liu wrote: > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > a random upper 32 bit feature bits, as the following io port read reads > lower 32 bit only. It could lead a feature bits that include > VIRTIO_F_VERSION_1 > (the 32th bit) for l

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-10 Thread Yuanhan Liu
Declare dst as type uint32_t instead of uint64_t, otherwise, we will get a random upper 32 bit feature bits, as the following io port read reads lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1 (the 32th bit) for legacy virtio, which is obviously wrong. Fixes: b8f045

[dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio

2016-03-10 Thread David Marchand
On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu wrote: > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > a random upper 32 bit feature bits, as the following io port read reads > lower 32 bit only. It could lead a feature bits that include > VIRTIO_F_VERSION_1 > (the 32th