On Mon, Mar 14, 2016 at 08:44:32PM +0800, Yuanhan Liu wrote:
> On Mon, Mar 14, 2016 at 10:48:31AM +0000, Bruce Richardson wrote:
> > On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote:
> > > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote:
> > > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu
> > > > <yuanhan.liu at linux.intel.com> wrote:
> > > > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will
> > > > > get
> > > > > a random upper 32 bit feature bits, as the following io port read
> > > > > reads
> > > > > lower 32 bit only. It could lead a feature bits that include
> > > > > VIRTIO_F_VERSION_1
> > > > > (the 32th bit) for legacy virtio, which is obviously wrong.
> > > > >
> > > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API")
> > > > >
> > > > > Cc: David Marchand <david.marchand at 6wind.com>
> > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> > > >
> > > > Argh, good catch.
> > > > Relooked at my patch, this should be the only bug (of this kind ;-)).
> > >
> > > Yes, I also have a check while making this patch.
> > >
> > > --yliu
> > > >
> > > > Reviewed-by: David Marchand <david.marchand at 6wind.com>
> > > >
> > > >
> > > > --
> > > > David Marchand
> > Hi,
> >
> > this patch no longer applies to dpdk-next-net/rel_16_04 branch due to
> > changes
> > in legacy_get_features function.
>
> Hi Bruce,
>
> It's a patch based on Thomas' tree. And this patch fixes an regression
> at there, too.
>
> --yliu
>
Ok, thanks for the info.
Thomas, I'm delegating this patch to you in patchwork to apply to your tree.
/Bruce
