Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-10 Thread David Marchand
On Thu, Oct 28, 2021 at 2:25 PM Ananyev, Konstantin wrote: > > Add the test content of the fragment_offset(offset and MF) > > to the test_ip_frag function. Add test data for a fragment > > that is not the last fragment. > > > > Signed-off-by: huichao cai > Acked-by: Konstantin Ananyev Applied,

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread Huichao Cai
>You seem ok with this title, I'll go with it. -Thank you!

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread David Marchand
On Tue, Nov 9, 2021 at 10:03 AM Huichao Cai wrote: > >It could (should?) have been a single patch. > --Yes, it can.I think the test unit is missing the offsets test content, so > add this patch, and can also test the previous patch. Too late, Thomas merged the fix in the library already. Please

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread Huichao Cai
Hi Marchand I think it should be a matter of message text format, maybe I should send a link in text form, as follows： https://patchwork.dpdk.org/project/dpdk/patch/1635148553-50086-1-git-send-email-chcch...@163.com/ Thank you! Huichao Cai

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread Huichao Cai
Hi Marchand >It could (should?) have been a single patch. --Yes, it can.I think the test unit is missing the offsets test content, so add this patch, and can also test the previous patch. >A link to patchwork would avoid me wasting time looking for it. >I guess this is the patch Thomas

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread David Marchand
Hello, On Tue, Nov 9, 2021 at 3:22 AM Huichao Cai wrote: > >6-0: checking 6688 with 3360 > > This test case failed because there was a bug in the > "rte_ipv4_fragmentation.c" file. > It is this test case that discovers this bug. A patch to fix the bug has been > received. Why was it separate f

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-08 Thread Huichao Cai
Hi Marchand >6-0: checking 6688 with 3360 This test case failed because there was a bug in the "rte_ipv4_fragmentation.c" file. It is this test case that discovers this bug. A patch to fix the bug has been received. Please run ci again.Thanks. The fix bug patche is: ip_frag: fix the buf of frag

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-08 Thread David Marchand
On Mon, Oct 25, 2021 at 9:59 AM huichao cai wrote: > > Add the test content of the fragment_offset(offset and MF) > to the test_ip_frag function. Add test data for a fragment > that is not the last fragment. > > Signed-off-by: huichao cai The CI raises a regression on the ip frag test. DPDK_TES

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-10-28 Thread Ananyev, Konstantin
> Add the test content of the fragment_offset(offset and MF) > to the test_ip_frag function. Add test data for a fragment > that is not the last fragment. > > Signed-off-by: huichao cai > --- > app/test/test_ipfrag.c | 95 > +- > 1 file changed,

[dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-10-25 Thread huichao cai
Add the test content of the fragment_offset(offset and MF) to the test_ip_frag function. Add test data for a fragment that is not the last fragment. Signed-off-by: huichao cai --- app/test/test_ipfrag.c | 95 +- 1 file changed, 79 insertions(+), 16