Hello,

On Tue, Nov 9, 2021 at 3:22 AM Huichao Cai <chcch...@163.com> wrote:
> >6-0: checking 6688 with 3360
>
> This test case failed because there was a bug in the 
> "rte_ipv4_fragmentation.c" file.
> It is this test case that discovers this bug. A patch to fix the bug has been 
> received.

Why was it separate from the fix?
I could not tell from this current patch that there was a dependency.
It could (should?) have been a single patch.


> The fix bug patche is:
> ip_frag: fix the buf of fragmenting IPv4 fragment - Patchwork (dpdk.org)

A link to patchwork would avoid me wasting time looking for it.
I guess this is the patch Thomas merged last night.


On the patch itself, the title is vague.
It should summarize what the change adds to the unit tests.
test/ipfrag: check fragment offsets

Thanks.

-- 
David Marchand

Reply via email to