Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-04-18 Thread Dai, Wei
First of all, I agree usage of IXGBE_FLAG_NEED_LINK_CONFIG to trigger link setup when link is up again. Both ixgbe_get_link_capabilities( ) and ixgbe_setup_link( ) calls different sub-function for different ixgbe MAC type including 82598, 82599, X540 and X550 and so on. I think ixgbe_setup_lin

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-04-12 Thread Laurent Hardy
In case of fiber and link speed set to 1Gb at peer side (with autoneg or with defined speed), link status could be not properly updated at time cable is plugged-in. Indeed if cable was not plugged when device has been configured and started then link status will not be updated properly with new spe

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-02-12 Thread Dai, Wei
> -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Thursday, February 9, 2017 1:03 AM > To: Dai, Wei > Cc: Laurent Hardy ; Zhang, Helin > ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: ensur

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-02-08 Thread Olivier MATZ
> > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated > > > > In case of link speed set to 1Gb at peer side (with autoneg or with > > defined speed) and cable not plugged-in when device is configured > > and started, the

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-02-08 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Laurent Hardy > Sent: Friday, November 18, 2016 1:30 AM > To: Zhang, Helin ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-02-01 Thread Thomas Monjalon
2016-12-08 17:10, Ferruh Yigit: > On 11/28/2016 5:27 PM, Laurent Hardy wrote: > > Hello, > > Is there anyone available to review this patch ? > > Adding more developers into cc. This patch is dying: more than 2 months without any review! A tip to help ixgbe maintainers in their task, please chec

Re: [dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2016-12-08 Thread Ferruh Yigit
On 11/28/2016 5:27 PM, Laurent Hardy wrote: > Hello, > Is there anyone available to review this patch ? Adding more developers into cc. > > regards, > Laurent > <...>

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2016-11-28 Thread Laurent Hardy
Hello, Is there anyone available to review this patch ? regards, Laurent On 11/17/2016 06:29 PM, Laurent Hardy wrote: > In case of link speed set to 1Gb at peer side (with autoneg or with > defined speed) and cable not plugged-in when device is configured > and started, then link status is not up

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2016-11-17 Thread Laurent Hardy
In case of link speed set to 1Gb at peer side (with autoneg or with defined speed) and cable not plugged-in when device is configured and started, then link status is not updated properly with new speed as no link setup is triggered. To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a